[Pymilter] [PATCH] Accept DNS names in iniplist

Stuart D Gathman stuart at bmsi.com
Wed Mar 26 10:20:10 EDT 2014


On 03/25/2014 02:36 PM, David Caldwell wrote:
>
>> This is a good idea.  The patch does not handle cidr, however, and
>> I'm pretty sure from eyeballing it that it doesn't work for IP6 either.
>> I'll polish it up and add it, however.
> I've never seen the cidr slash notation used with DNS names, so I
> explicitly chose not to support that. You're probably right about IPv6.
> I don't really have a way to test that and just hoped for the best. :-)
> Though I guess you'd need to look up both A and AAAA records, which I
> didn't do.
Hmm, if expanding within iniplist(), like you did, it can lookup only A 
records when ip is IP4 and only AAAA records when ip is IP6. I can call 
recursively to handle the CIDR rather than duplicate the code.



More information about the Pymilter mailing list